elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.63k stars 8.22k forks source link

Remove license checks from ES UI Basic-licensed plugins #97314

Open cjcenizal opened 3 years ago

cjcenizal commented 3 years ago

Per https://github.com/elastic/kibana/pull/95973#pullrequestreview-636650158, many of ES UI's Basic-licensed apps implement an unnecessary server-side license check. See for example: Ingest Node Pipelines, Index Management and ILM). We can remove these since Basic-licensed apps will be unrestricted under any license.

elasticmachine commented 3 years ago

Pinging @elastic/es-ui (Team:Elasticsearch UI)

cjcenizal commented 3 years ago

I'm working through ILM and I just found out that it does its own fetching of snapshot policies and snapshot repositories, which are available under the Enterprise license. These entities are used to power the searchable snapshots and "Wait for snapshot before deleting" functionality, respectively.

I wonder if we should create an optional dependency upon the Snapshot and Restore plugin and use its APIs to fetch these entities instead?

Pros Cons
Single source of truth for fetching SR entities Theoretically, a user might disable the SR plugin in Kibana without disabling it in ES, creating a false dependency
Reduced code
We can disable the relevant UI if the plugin is disabled

This boils down to the essential question: is it fair and realistic to assume the ES SR functionality is available if the Snapshot and Restore plugin is enabled? FWIW, this plugin is enabled in Cloud, despite Cloud having its own backups UI.

elasticmachine commented 1 month ago

Pinging @elastic/kibana-management (Team:Kibana Management)