elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

[Discover] Paging through records with mouse or keyboard should update flyout contents #99115

Closed shaunmcgough closed 1 year ago

shaunmcgough commented 3 years ago

When the new data grid is enabled, if you click on a row or arrow through the rows of records, it should update the display of the flyout to reflect the record you've clicked on (regardless of the field you clicked), and also highlight that row in yellow (as it does when you click the expand arrows.

Screen Shot 2021-05-03 at 3 50 16 PM
elasticmachine commented 3 years ago

Pinging @elastic/kibana-app (Team:KibanaApp)

timroes commented 3 years ago

I have some a11y concerns around this. In my opinion a behavior like this will break hardly on WCAG 3.2.1 since we're changing context in a non focused part of the UI, by pure focus changes in another part of the UI. cc @myasonik I would like to get your opinion on this suggestion before we consider this.

myasonik commented 3 years ago

It would take some careful work but there are certainly ways we could do this.

WCAG 3.2.1 is pretty easy to avoid running into issues on by not moving focus to the flyout whenever the row changes.

But to do that, we need to have an aria-live region that will announce to screen readers that another part of the page has changed.

To visually better support this split panel design, you might also want to consider the upcoming push flyout style to actually have the table and flyout side-by-side rather than a flyout over the table that you're also supposed to be interacting with.

kertal commented 1 year ago

Requirement for this, using the push flyout https://github.com/elastic/kibana/issues/148902

kertal commented 1 year ago

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.