Closed tsullivan closed 3 years ago
Pinging @elastic/kibana-app (Team:KibanaApp)
Pinging @elastic/kibana-presentation (Team:Presentation)
Context info about this bug:
When the user selects "Optimize for printing," it changes the layout
field of the report job params from preserve
to print
. This gets used later, when the report job is running async on the server. The screenshot capture pipeline detects the layout type, and injects CSS into the page to force a change of layout.
print_layout
: https://github.com/elastic/kibana/blob/f07ebc8/x-pack/plugins/reporting/server/lib/layouts/print.cssI think an acceptable bug fix for this issue would be to update the print.css
file so that the injected styles work better with the new visualization CSS code.
For longer term, the Reporting plugin should not inject CSS into the page:
Duplicate of https://github.com/elastic/kibana/issues/23289
@tsullivan I'm not certain this is a duplicate of that old issue, this is possibly something that was introduced recently. It looks like our injected reporting styles no longer have an effect on the dashboard since the wrapping dshAppContainer
class was removed. Looks like this was the commit:
~Might be mistaken though!~ Tested this locally and it looks like adding that wrapping element + class back fixes dashboard pdfs. Although we should probably consider a different approach to re-applying injected styles.
I agree, it looks like this change introduced the issue that I found, but the bug I linked to is a bit older.
Kibana version: 7.x (7.14.0-SNAPSHOT)
Original install method (e.g. download page, yum, from source, etc.): Running from source
Describe the bug: When you create a PDF export of a dashboard using the "Print layout" option, some visualization types are corrupting pages of the PDF.
Steps to reproduce:
Expected behavior: This feature is working OK in 7.13
Screenshots (if relevant): PDF file: [eCommerce] Revenue Dashboard.pdf
Errors in browser console (if relevant):