Open stacey-gammon opened 3 years ago
Pinging @elastic/kibana-app-services (Team:AppServices)
I think that the common
export *
are intentional, as we expose the explicit APIs from public
and server
. Isn't it so?
@lizozom, afaik nothing blocks other's importing from common
. Also, they have to import from common
if they import into their common
. So looks export from common
still should be limited.
Sounds like there's going to be a lot more repeated code then :-) Not sure if I'm a huge fan 🤷🏻
Any update on this? This is an important step towards reducing the size of the data plugin's public API, which is comprised of 3716 items.
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)
export *
makes it easy for a developer to accidentally expose functionality on a plugin's public API, and so should be avoided in favor of explicit exports.Looks like
data/common/index.ts
has quite a few: https://github.com/elastic/kibana/blob/master/src/plugins/data/common/index.ts#L9