detect log4j2.properties, disable log level if defined

elastic / libesvm

A library for managing instances of Elasticsearch

7 stars 14 forks source link

detect log4j2.properties, disable log level if defined #40

Closed jbudz closed 8 years ago

jbudz commented 8 years ago

Elasticsearch recently upgraded from log4j to log4j2. As part of this upgrade, the logging.yml wrapper around log4j properties was removed and a raw properties file is exposed instead. This PR adds feature detection for the log file type, and disables log level configuration if using a log4j2 properties file. This is a partial fix to get esvm running, a full solution will require parsing the new configuration format.

jbudz commented 8 years ago

Last commit is broken, fixing it in a minute.

jbudz commented 8 years ago

Should be good now.

spalger commented 8 years ago

LGTM, unable to test against a recent snapshot of master, but implementation looks good and it works logging.yml snapshots.