Ignoring ENOENT on cache.clear

elastic / libesvm

A library for managing instances of Elasticsearch

7 stars 14 forks source link

Ignoring ENOENT on cache.clear #54

Closed kobelb closed 6 years ago

kobelb commented 6 years ago

https://github.com/elastic/libesvm/pull/50 introduced a bug where if the cache.json doesn't exist, the unlink call was returning an ENOENT error which wasn't being ignored.

kobelb commented 6 years ago

@jbudz brought up a good point, that the usage of cache.clear expects the cb to be called and a Promise to be returned... this approach needs to be revised.

kobelb commented 6 years ago

Deferring to @jbudz PR instead, it's better https://github.com/elastic/libesvm/pull/53