search

elastic / logstash-devutils

An assortment of tooling/libraries to make Logstash core and plugin development and releasing a bit easier.
Apache License 2.0
18 stars 27 forks source link

Respect `default_type` #64

Closed joshuaspence closed 4 years ago

joshuaspence commented 7 years ago

LogStashHelper currently provides a type method which seems to be able to be used for setting a default type field for LogStash::Event objects. The default_type variable, however, is never actually read.

joshuaspence commented 7 years ago

@ph, any chance of having this PR reviewed?

kares commented 4 years ago

Thanks for the effort Joshua, types are obsolete these day - so we won't need this (anymore). https://github.com/elastic/logstash-devutils/commit/5a06e61bfdc9bf36d5bc6dd932e3462b4b637080#diff-d0ea000d0dc9e43979d1a928418aee9bR47