search

elastic / logstash-devutils

An assortment of tooling/libraries to make Logstash core and plugin development and releasing a bit easier.
Apache License 2.0
17 stars 29 forks source link

close pipeline after #sample helper and bump version to 1.3.1 #67

Closed colinsurprenant closed 7 years ago

colinsurprenant commented 7 years ago

For logstash-core 5.3 which requires the pipeline to be closed after initialization.

This change is backward compatible by checking if the Pipeline#close method exists.

Required for elastic/logstash/pull/6656

jordansissel commented 7 years ago

LGTM; haven't tested.

ph commented 7 years ago

Can you update the changelog https://github.com/elastic/logstash-devutils/blob/master/CHANGELOG.md ?

colinsurprenant commented 7 years ago

@ph aw crap, yes :P

colinsurprenant commented 7 years ago

merged into master. Thanks @ph @jordansissel

colinsurprenant commented 7 years ago

pushed version 1.3.1 to rubygems.