search

elastic / logstash-devutils

An assortment of tooling/libraries to make Logstash core and plugin development and releasing a bit easier.
Apache License 2.0
17 stars 29 forks source link

BUG: Return empty array instead of nil from filter test util #75

Closed original-brownbear closed 6 years ago

original-brownbear commented 6 years ago

output_func always returns an array no matter what. dev-utils behavior must be in line with production code here to fix builds like this one https://travis-ci.org/logstash-plugins/logstash-input-elasticsearch/jobs/284374623#L1137 (elasticsearch input is broken with LS master atm).

I caused this here https://github.com/elastic/logstash/pull/8446/files#diff-bc1e9ea81caa54ea0d56abf4415fdf00R524 accidentally because I couldn't find any specs that required the removed hack. Now I found them ...this should fix all cases though for LS pre and post that commit.

jsvd commented 6 years ago

LGTM. please include a version bump.

this means we should make this version the minimum required versions for logstash master/6.x/6.0/5.6 in the Gemfile.template, right?

original-brownbear commented 6 years ago

@jsvd yea we should, will bump version and add LS PR once merged/released

original-brownbear commented 6 years ago

changelog and version bumped :)

elasticsearch-bot commented 6 years ago

Armin Braun merged this into the following branches!

Branch Commits
master d72c45ef6b5c9fa440821028630e733d17172505, e406a6ce744db7c6667934d528ee5ff7e4c5f3a0