search

elastic / logstash-filter-elastic_integration

The Elastic Integrations filter for Logstash, which enables running Elastic Integrations inside of Logstash pipelines
Other
2 stars 9 forks source link

Doc: Formatting fixes #115

Closed karenzone closed 10 months ago

karenzone commented 10 months ago

Fixes: #82

karenzone commented 10 months ago

@mashhurs The extra + signs in source are rendering literally throughout the page. Here's an example:

Screen Shot 2023-12-19 at 5 27 24 PM

I'm guessing that you want these entries to be literal? For example (borrowed from screenshot): _none, pipeline => "none", _ingest_pipeline_failure. Is that correct? If so, I'll fix those instances as part of this PR.

karenzone commented 10 months ago

@mashhurs, please take a look and share your thoughts. When we're done, I'll bump versions and publish to get these docs building for the Logstash Reference.

mashhurs commented 10 months ago

@mashhurs The extra + signs in source are rendering literally throughout the page. Here's an example:

Screen Shot 2023-12-19 at 5 27 24 PM

I'm guessing that you want these entries to be literal? For example (borrowed from screenshot): _none, pipeline => "none", _ingest_pipeline_failure. Is that correct? If so, I'll fix those instances as part of this PR.

That's correct @karenzone ! Thank you for catching up.

karenzone commented 10 months ago

Thanks for the confirmation, @mashhurs. I'll fix it tomorrow.

karenzone commented 10 months ago

@mashhurs, new commits caused your review to be dismissed. Can I get a fresh LGTM, please?

karenzone commented 10 months ago

Published at v.0.1.3