search

elastic / logstash-forwarder

An experiment to cut logs in preparation for processing elsewhere. Replaced by Filebeat: https://github.com/elastic/beats/tree/master/filebeat
Other
1.79k stars 415 forks source link

Minor miss in lumberjack documentation #560

Closed AnderssonPeter closed 7 years ago

AnderssonPeter commented 7 years ago

https://github.com/elastic/logstash-forwarder/blob/master/PROTOCOL.md

Payload:

32bit unsigned sequence number
32bit 'pair' count (how many key/value sequences follow)
32bit unsigned key length followed by that many bytes for the key
32bit unsigned value length followed by that many bytes for the value
repeat key/value 'count' times.

Is the 'pair' count signed or unsigned?

jordansissel commented 7 years ago

Unsigned: https://github.com/elastic/logstash-forwarder/blob/master/publisher1.go#L231

AnderssonPeter commented 7 years ago

@jordansissel Thanks