search

elastic / logstash

Logstash - transport and process your logs, events, or other data
https://www.elastic.co/products/logstash
Other
14.18k stars 3.5k forks source link

CLI integration plugin acceptance tests are failing #10459

Open robbavey opened 5 years ago

robbavey commented 5 years ago 
21:08:08 Failures:
21:08:08 
21:08:08   1) CLI operation behaves like integration plugins compatible logstash-plugin install on debian-8 when the integration is not installed if an inner plugin is installed installing the integrations uninstalls the inner plugin
21:08:08      Failure/Error: expect(result.stdout).to_not match(/^logstash-input-rabbitmq/)
21:08:08        expected "logstash-input-rabbitmq\nlogstash-integration-rabbitmq\n \xE2\x94\x9C\xE2\x94\x80\xE2\x94\x80 logstash-input-rabbitmq\n \xE2\x94\x94\xE2\x94\x80\xE2\x94\x80 logstash-output-rabbitmq\n" not to match /^logstash-input-rabbitmq/
21:08:08        Diff:
21:08:08        @@ -1,2 +1,5 @@
21:08:08        -/^logstash-input-rabbitmq/
21:08:08        +logstash-input-rabbitmq
21:08:08        +logstash-integration-rabbitmq
21:08:08        + ????????? logstash-input-rabbitmq
21:08:08        + ????????? logstash-output-rabbitmq
21:08:08      Shared Example Group: "integration plugins compatible" called from /var/lib/jenkins/workspace/elastic+logstash+7.x+multijob-acceptance/label/metal/suite/debian/qa/acceptance/spec/lib/cli_operation_spec.rb:24
21:08:08      # /var/lib/jenkins/workspace/elastic+logstash+7.x+multijob-acceptance/label/metal/suite/debian/qa/acceptance/spec/shared_examples/cli/logstash-plugin/integration_plugin.rb:36:in `block in (root)'
21:08:08      # /var/lib/jenkins/workspace/elastic+logstash+7.x+multijob-acceptance/label/metal/suite/debian/qa/Rakefile:73:in `block in (root)'
jsvd commented 5 years ago

This is really strange. it seems that after installing the integration plugin the previously installed rabbitmq input is still there, but I can't replicate locally:

joaoduarte@overcraft /tmp/logstash-6.7.0 % bin/logstash-plugin install logstash-input-rabbitmq
Validating logstash-input-rabbitmq
Installing logstash-input-rabbitmq
Installation successful
bin/logstash-plugin install logstash-input-rabbitmq  11.08s user 1.09s system 66% cpu 18.287 total
joaoduarte@overcraft /tmp/logstash-6.7.0 % bin/logstash-plugin list logstash-input-rabbitmq
logstash-input-rabbitmq
bin/logstash-plugin list logstash-input-rabbitmq  7.59s user 0.75s system 180% cpu 4.617 total
joaoduarte@overcraft /tmp/logstash-6.7.0 % bin/logstash-plugin install logstash-integration-rabbitmq
Validating logstash-integration-rabbitmq
Installing logstash-integration-rabbitmq
Installation successful
Removing 'logstash-input-rabbitmq' since it is provided by an integration plugin
Successfully removed logstash-input-rabbitmq
Removing 'logstash-output-rabbitmq' since it is provided by an integration plugin
Successfully removed logstash-output-rabbitmq
bin/logstash-plugin install logstash-integration-rabbitmq  21.37s user 2.15s system 34% cpu 1:07.61 total
joaoduarte@overcraft /tmp/logstash-6.7.0 % bin/logstash-plugin list logstash-input-rabbitmq
logstash-integration-rabbitmq
 ├── logstash-input-rabbitmq
 └── logstash-output-rabbitmq
jsvd commented 5 years ago

same with docker and 6.6.0:

% docker build .
Sending build context to Docker daemon  2.048kB
Step 1/6 : FROM docker.elastic.co/logstash/logstash:6.6.0
 ---> 8f45a7702366
Step 2/6 : WORKDIR /usr/share/logstash
 ---> Running in e900b3278c4b
Removing intermediate container e900b3278c4b
 ---> fbe8f7624668
Step 3/6 : RUN bin/logstash-plugin install logstash-input-rabbitmq
 ---> Running in f7b3b99b5240
Validating logstash-input-rabbitmq
Installing logstash-input-rabbitmq
Installation successful
Removing intermediate container f7b3b99b5240
 ---> daa7f226f20e
Step 4/6 : RUN bin/logstash-plugin list logstash-input-rabbitmq
 ---> Running in 83ccdad35149
logstash-input-rabbitmq
Removing intermediate container 83ccdad35149
 ---> b0d2ad553f9a
Step 5/6 : RUN bin/logstash-plugin install logstash-integration-rabbitmq
 ---> Running in 0a90c3131f9e
Validating logstash-integration-rabbitmq
Installing logstash-integration-rabbitmq
Installation successful
Removing 'logstash-input-rabbitmq' since it is provided by an integration plugin
Resolving dependencies..............
Resolving dependencies...............
Successfully removed logstash-input-rabbitmq
Removing 'logstash-output-rabbitmq' since it is provided by an integration plugin
Resolving dependencies...............
Resolving dependencies..............
Successfully removed logstash-output-rabbitmq
Removing intermediate container 0a90c3131f9e
 ---> 5635b021004d
Step 6/6 : RUN bin/logstash-plugin list logstash-input-rabbitmq
 ---> Running in 057cf62b7919
logstash-integration-rabbitmq
 ├── logstash-input-rabbitmq
 └── logstash-output-rabbitmq
Removing intermediate container 057cf62b7919
 ---> d5453494e0c4
Successfully built d5453494e0c4