Option to update a plugin to a specific version

elastic / logstash

Logstash - transport and process your logs, events, or other data

https://www.elastic.co/products/logstash

Other

69 stars 3.5k forks source link

Option to update a plugin to a specific version #4369

Open acchen97 opened 8 years ago

acchen97 commented 8 years ago

There are use cases where a user may need to update a plugin to a particular version that isn't the latest. There should be a --version flag for "bin/plugin update" to enable this.

More context here: https://github.com/elastic/logstash/issues/3334

purbon commented 8 years ago

In my opinion the most important thing to provide here is idempotent updates command, and this will be hard to archive only with a ---version flag, obviously this should be be skip as is a good feature to have for the update command. I some challenges here:

We provide no feedback to our users when hitting plugin dependencies conflicts. I started an small effort, that needs a bit of polishing at (https://github.com/elastic/logstash/pull/4288) to address this problem.
We should provide idempotent updates across machines, this will be challenging only with adding the ---version flag, due to possible inter plugin conflicts. Some of this might be archived by sharing the install status (aka Gemfile.lock file).

what do you think?

acchen97 commented 8 years ago

@purbon I agree idempotent updates are important and I think the --version flag should solve it if we resolve the conflicts within the update operation (update or uninstall dependent plugins).

The current way to install a specific version of a plugin is to uninstall all plugins that depend on it first, then uninstall the actual plugin and reinstall it with "install --version".

Uninstall command user feedback is another item, success and failure (+reasons why) should be clearly displayed and I'm +1 on more feedback here.

ppuschmann commented 8 years ago

Let's give an example to this request:

Scenario:

Kafka 0.9 Cluster shall get used with Logstash 2.4

According to https://github.com/logstash-plugins/logstash-output-kafka we should use plugin version 4.0.0 to use the correct plugin version to work with Kafka 0.9 brokers.

-> How do I install this version 4.0.0 on the cli?

bin/logstash-plugin install logstash-output-kafka --version 4.0.0 does not work.

Right now I somehow have to do this manually, wasting some precious time on how to automate/script this.

raiusa commented 8 years ago

@ppuschmann I have the same use case and trying to make it working. Can you please guide me what manual step you have done?

wongchao commented 7 years ago

any solution here?

acchen97 commented 7 years ago

@wongchao the current workaround here is to uninstall and reinstall with the desired plugin version.

ppuschmann commented 7 years ago

@raiusa I have no workaround. We "fixed" this by installing a newer version of Logstash that already shipped with a plugin that is (more) compatible to our kafka-broker version.