search

elastic / logstash

Logstash - transport and process your logs, events, or other data
https://www.elastic.co/products/logstash
Other
90 stars 3.5k forks source link

Make Logstash complain if attempting to use batch_count (redis input plugin) with a single-threaded filter plugin. #4625

Open buddyp450 opened 8 years ago

buddyp450 commented 8 years ago

I tried to use a configuration today by accident that included the redis input plugin's batch_count setting as well as a zeromq filter in the same configuration.

Zeromq requires that it be single threaded and I know that logstash can detect that but for some reason after setting the batch_count in the redis input plugin, it starts up and doesn't complain at all.

I finally found it when I went into the configuration file and noticed the setting after I determined it wasn't ingesting from it's input.

I think it would be helpful if logstash complained about this setting either through configtest or otherwise.

andrewvc commented 8 years ago

@buddyp450 thanks for reporting this. The real fix is to just make the zmq filter threadsafe . I've started work toward that here: https://github.com/logstash-plugins/logstash-filter-zeromq/issues/10 if I release that as a beta gem would you be willing to help test it?

buddyp450 commented 8 years ago

I will be testing your pull request today.

andrewvc commented 8 years ago

@buddyp450 thanks! If the test passes, please update this ticket and I'll release a new version of the plugin. Its not really a supported plugin, so this is the best testing we can do :-/