search

elastic / logstash

Logstash - transport and process your logs, events, or other data
https://www.elastic.co/products/logstash
Other
14.2k stars 3.5k forks source link

Quotes do not work with codecs + extended attributes #5061

Open andrewvc opened 8 years ago

andrewvc commented 8 years ago

Codecs with quoted names plus extended options are no longer valid in 2.3.x. For instance codec => json {opt => val}. See https://discuss.elastic.co/t/quotes-in-config-files-v2-3-0/46563/7

colinsurprenant commented 8 years ago

We should first verify that

  1. this was ever documented or shown in any examples as a valid syntax
  2. and if this was never an advertised valid syntax, we should verify that the fact it was working prior to 2.3 releases is not just a side effect of some other changes?

Personally I have never seen a quoted codec name and I don't see how/when this could ever be useful?

StephenGoodall commented 8 years ago

I found this in the documentation: http://screencast.com/t/K5ge8lgKEW

https://www.elastic.co/guide/en/logstash/current/configuration-file-structure.html#codec

Which I got to from: https://www.elastic.co/guide/en/logstash/current/plugins-inputs-s3.html#plugins-inputs-s3-codec

Hope this helps :)

colinsurprenant commented 8 years ago

:boom: thanks @StephenGoodall :D that pretty much answers my previous comment ... let's fix that. I am still curious to see if this was working in < 2.x releases, but probably, will verify.