I activated the javac linter warnings in #7674 and we have many of them showing in each build.
Some of them are somewhat irrelevant, especially those in test code, but others in production code point us towards clear code smells like the many chained instanceof calls we have.
We should clean these up where possible and suppress them where it isn't.
liketic
commented
6 years ago
I activated the
javaclinter warnings in #7674 and we have many of them showing in each build. Some of them are somewhat irrelevant, especially those in test code, but others in production code point us towards clear code smells like the many chainedinstanceofcalls we have.We should clean these up where possible and suppress them where it isn't.