elastic / logstash

Logstash - transport and process your logs, events, or other data
https://www.elastic.co/products/logstash
Other
90 stars 3.5k forks source link

Update dependency of octokit (at least ~>4.6) #8819

Open Benedikt1992 opened 6 years ago

Benedikt1992 commented 6 years ago

I'm currently developing a logstash input plugin to get log files from google cloud storage service.

Most of the google cloud gems have a dependency on faraday ~> 0.12. Unfortunately the version of octokit required by logstash relies on faraday < 0.10, ~> 0.8. This can't be resolved (obviously).

octokit has alredy updated their dependencies. Since version 4.6.0 it relies on faraday <1.0, ~>0.8. This could be resolved.

If the version is not updated logstash is incompatible to most of the google cloud services.

Plugin version conflict, aborting
ERROR: Installation Aborted, message: Bundler could not find compatible versions for gem "faraday":
  In snapshot (Gemfile.lock):
    faraday (= 0.9.2)

  In Gemfile:
    octokit (= 3.8.0) java depends on
      sawyer (>= 0.5.3, ~> 0.6.0) java depends on
        faraday (< 0.10, ~> 0.8) java

    logstash-input-twitter (>= 0) java depends on
      twitter (= 5.15.0) java depends on
        faraday (~> 0.9.0) java

    logstash-core (>= 0) java depends on
      elasticsearch (>= 5.0.4, ~> 5.0) java depends on
        elasticsearch-transport (= 5.0.4) java depends on
          faraday (>= 0) java

    logstash-input-gcsfork (= 0.1.0) java depends on
      google-cloud-storage (~> 1.9) java depends on
        googleauth (~> 0.6.2) java depends on
          faraday (~> 0.12) java
jordansissel commented 6 years ago

@Benedikt1992 octokit is listed as a build dependency only and is not used for logstash at run-time. This must be a bug in how we build Logstash that octokit is causing you problems.

That said, we can also try upgrading octokit, but doing so is a workaround for the real problem which is logstash releases incorrectly including a dependency on octokit.

Benedikt1992 commented 6 years ago

@jordansissel Thank you for your reply. In this case it may becomes important that I'm using the docker image logstash-oss:6.0.0

Benedikt1992 commented 6 years ago

With logstash-oss:6.0.1 the issue persists