search

elastic / logstash

Logstash - transport and process your logs, events, or other data
https://www.elastic.co/products/logstash
Other
78 stars 3.5k forks source link

are both vendor/jruby and logstash-core/lib/jars/jruby-complete-9.1.13.0.jar required? #9748

Open colinsurprenant opened 6 years ago

colinsurprenant commented 6 years ago

We actually use two JRuby distributions in logstash:

Are both strictly required? couldn't we get rid of vendor/jruby and only rely on logstash-core/lib/jars/jruby-complete-9.1.13.0.jar ?

original-brownbear commented 6 years ago

@colinsurprenant yea theoretically we could get rid of vendor/jruby. We actually did get rid of it in a number of places lately (integration tests, x-pack specs, x-pack integration tests). Unfortunately there's still spots left that will require a Java wrapper to get rid of the scripting vendor/jruby provides. At this point it's at least (and I'm probably missing some) the plugin manager (this one is the only one that's gonna be a little more work to wrap though), the acceptance tests and the license checks.