search

elastic / makelogs

109 stars 44 forks source link

Use `_doc` instead of `doc` mapping #43

Closed jen-huang closed 6 years ago

jen-huang commented 6 years ago

Use _doc instead of doc type mapping to match ES convention and to be forward compatible when types are removed.

Tested and it works. If you have already used makelogs to create logstash-* previously, and do not allow makelogs to replace the indices/index templates, there will be an error about multiple mappings: Rejecting mapping update to [logstash-0] as the final mapping would have more than 1 type: [doc, _doc]

Easiest solution is to just let makelogs replace the indices and corresponding templates.

rhoboat commented 6 years ago

This is a good change. I'm not back until July 9, but so I'm refraining from pulling and testing, but the code LGTM.

spalger commented 6 years ago

Just published in v4.2.0 🍁