[7.17] [ML] Include an extra header in CDataFrameRowSlice

elastic / ml-cpp

Machine learning C++ code

Other

7 stars 62 forks source link

[7.17] [ML] Include an extra header in CDataFrameRowSlice #2565

Closed droberts195 closed 1 year ago

droberts195 commented 1 year ago

Our two ARM macOS build servers have somehow ended up running different versions of Xcode - one is running version 12 and the other version 13.

There have been changes to the C++ standard library between these versions that reveal a technical violation that we were previously getting away with: CDataFrameRowSlice.cc uses file streams without including the necessary header. Previously it must have been indirectly included. This PR includes it explicitly.

Backport of #2563

droberts195 commented 1 year ago

Java integration test failure is because the Elasticsearch version bump is out-of-sync with ML. Merging anyway.