search

elastic / ml-cpp

Machine learning C++ code
Other
149 stars 62 forks source link

[ML] Set buildkite_branch_name_separator to "+" #2641

Closed edsavage closed 5 months ago

edsavage commented 6 months ago

To work around a problem with BuildKite PR builds on bare metal machines (currently only macOS aarch64 builds), set the value of the character separating username and branchname to be "+" rather than the default ":"

Marking as >non-issue as this only affects the internal build system and is not worthy of a release note.

edsavage commented 6 months ago

buildkite build this

droberts195 commented 5 months ago

I see that the PR CI failed with the same error:

2024-03-17 15:15:17 ERROR Could not obtain OIDC token for default audience 🚨 Error: Error setting up job executor: The global environment hook exited with status 1

Is the problem that the PR bot is always getting its config from main, so the change of this PR won't be picked up until after it's merged? If so, let's just merge this PR with red CI and hope the change works once it's on main.

jonahbull commented 5 months ago

Is the problem that the PR bot is always getting its config from main, so the change of this PR won't be picked up until after it's merged?

@droberts195 Yes, that's correct