elastic / ml-cpp

Machine learning C++ code
Other
149 stars 62 forks source link

[ML] Do not remove eigen directory as part of "clean" step #2649

Closed edsavage closed 4 months ago

edsavage commented 4 months ago

The scripts that clone the eigen repo already have logic to remove an existing directory structure prior to cloning, and removing it as part of the clean step forces a cmake reconfigure before subsequent builds will succeed (as the eigen headers will be missing)

Labelling as >non-issue as this only affects the build scripts.

jan-elastic commented 4 months ago

LGTM