elastic / ml-cpp

Machine learning C++ code
Other
149 stars 62 forks source link

[ML] Log 'No statistics at.. ' as a warning #2684

Closed davidkyle closed 1 month ago

davidkyle commented 2 months ago

The condition is considered harmless and should not be logged as an error

davidkyle commented 1 month ago

@edsavage this change was provoked by the error message below. Looking at the current bucket time [-1,899) I think it should have been fixed in #2410. Do you think there is still an issue here or we can go ahead and change the log level?

[gallery_sum_bytes] [autodetect/179] [CIndividualModel.cc@136] No statistics at 1719197550 for sum bytes partition=clientip, current bucket = [-1,899), partitionFieldValue = 175.144.21.153, personName = | repeated [5]
edsavage commented 1 month ago

@edsavage this change was provoked by the error message below. Looking at the current bucket time [-1,899) I think it should have been fixed in #2410. Do you think there is still an issue here or we can go ahead and change the log level?

[gallery_sum_bytes] [autodetect/179] [CIndividualModel.cc@136] No statistics at 1719197550 for sum bytes partition=clientip, current bucket = [-1,899), partitionFieldValue = 175.144.21.153, personName = | repeated [5]

I think that it's safe and appropriate to downgrade the log level for that message @davidkyle, thanks!