search

elastic / next-eui-starter

Start building Kibana protoypes quickly with the Next.js EUI Starter
https://elastic.github.io/next-eui-starter/
Apache License 2.0
93 stars 30 forks source link

Upgrade to Next 10 and EUI 30 #18

Closed pugnascotia closed 3 years ago

pugnascotia commented 3 years ago

This PR upgrades all dependencies, most notably Next.js and EUI.

In so doing, the navigation component from EUI that we used has been removed, so I've restyled the app to look like the EUI style guide.

Note as well that I had to set mainFields in the Webpack config, as otherwise it was trying to load from the lib dir in EUI instead of es. I assume this is due to internal Next change or their upgrade to Webpack 5.

pugnascotia commented 3 years ago

cc @snide for your interest

snide commented 3 years ago

Awesome. thanks @pugnascotia

miukimiu commented 3 years ago

@pugnascotia FYI this error was reported and it happened on a previous version of the starter: https://github.com/elastic/eui/issues/4227

Is this something that can be fixed with this upgrade?

pugnascotia commented 3 years ago

@miukimiu it's possible - a lot of the Next.js internals will have changed, I expect.

pugnascotia commented 3 years ago

@chandlerprall Any ideas for reducing the FOUC when changing themes? It's a bit harsh ☹️

pugnascotia commented 3 years ago

@chandlerprall I decided to merge this PR. If we have the time, we can look at the FOUC.