search

elastic / next-eui-starter

Start building Kibana protoypes quickly with the Next.js EUI Starter
https://elastic.github.io/next-eui-starter/
Apache License 2.0
93 stars 30 forks source link

Derive path prefix automatically and remove redundant mocks #8

Closed pugnascotia closed 4 years ago

pugnascotia commented 4 years ago

This PR does 2 unrelated things (sorry):

  1. Attempt to automatically derive the repository name, instead of hard-coding it.
  2. Remove the window and localStorage mocks, as they aren't needed to avoid failures when building static pages. What's more, the window mock was causing the build to explode when using the serverless build target. So this PR also closes #7.

I also raised https://github.com/vercel/next-site/issues/715 because the Next.js documentation is confusing on the subject of whether you should or shouldn't target serverless all the time.

pugnascotia commented 4 years ago

@chandlerprall I made some more fix-ups.