search

elastic / opentelemetry-lib

Apache License 2.0
0 stars 6 forks source link

Process and Network Metrics: Cumulative Sum Temporality #8

Closed ishleenk17 closed 1 month ago

ishleenk17 commented 1 month ago

Process and Network metrics are of cumulative sums temporality with monotonic values as per this discussion here. Filing this issue to carry forward the discussion to unblock the PR.

lahsivjar commented 1 month ago

I looked at the data produced by system-integration from system.network.* + one of the process metrics (system.process.io.write_ops) and it looks like these metrics are indeed cumulative sums. So, our remapping logic should be correct for these. We would need to fix https://github.com/elastic/opentelemetry-lib/issues/15 but other than that looks like these metrics are expected to be cumulative + monotonically increasing metrics.

There is an issue with the host.network.* metrics which is a delta cumulative metric but I have opened a separate issue for this: https://github.com/elastic/opentelemetry-lib/issues/14

@ishleenk17 While I have not asserted for correctness of ALL the process metrics given that you have already validated the metrics I think we can close the issue.

ishleenk17 commented 1 month ago

Closing the issue on the basis of above comment!