elastic / opentelemetry

Get started with our Elastic Distros of OpenTelemetry
11 stars 8 forks source link

fix: use node name for OTLP endpoint #20

Closed rogercoll closed 1 month ago

rogercoll commented 1 month ago

As the OTLP running as a daemonset, the receiver's port are exposed at node level. Thus we can refer it directly in the deployed instrumentation.

See another example: https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-kube-stack/examples/cloud-demo/values.yaml#L55

Differently than the example above, the OTEL_K8S_NODE_NAME environment variable notation is expanded using the Kubernetes nomenclature, thus relying on k8s for its expansion instead of the actual application.

rogercoll commented 1 month ago

Closed in favor of https://github.com/elastic/opentelemetry/pull/19