elastic / package-spec

EPR package specifications
Other
18 stars 72 forks source link

[Change Proposal] Validate top-level keys in Ingest Pipeline definition #529

Closed andrewkroh closed 11 months ago

andrewkroh commented 1 year ago

Currently there is no validation of the keys contained in Ingest Pipeline definitions. I propose we validate the top-level pipeline keys that we want to allow (description, processors, on_failure). We don't need validate deeper into the processors at this time.

Elasticsearch supports more key(s) like version, and I have seen this present in some pipeline definitions. But I think this version key should be prohibited in Fleet packages. It does not appear to be of use to Fleet and is confusing to have a version embedded in the pipeline that differs from the package version.

I discovered the version key already being used in a few places:

andrewkroh commented 11 months ago

Implemented by https://github.com/elastic/package-spec/pull/586