Assign error code to path_match in manifests

jsoriano commented 1 year ago

What does this PR do?

Assign new error code JSE00001 to validation errors raised when data streams define dynamic mappings with path_match in data stream manifests.

Why is it important?

Since Package Spec v3, it is mandatory to use field files to define fields that can be defined there. This is the case of dynamic fields with path_match. We have found that packages using these mappings and dynamic: "runtime" cannot ingest documents with the error Missing intermediate object labels, likely caused because the parent object doesn't exist in the mapping. We should probably make Fleet to create these intermediate objects. In the meantime, JSE00001 may offer a escape hatch for packages needing this, like in the test package added in this PR.

After this change, packages with this issue, can add a validation.yml file at the root of the package with the following content to ignore this error:

errors:
  exclude_checks:
    - JSE00001 # Data stream defines a dynamic mapping in manifest that should be defined in field files.

Checklist

[x] I have added test packages to test/packages that prove my change is effective.
[x] I have added an entry in spec/changelog.yml.

Related issues

This issue blocks https://github.com/elastic/apm-server/pull/11822

elasticmachine commented 1 year ago

:green_heart: Build Succeeded

Buildkite Build
Commit: e611a59ffe2bf8785d3fb0113997ad28f030f510

cc @jsoriano

jsoriano commented 1 year ago

Not needed by now, closing.

elastic / package-spec