Accept dashboards without filter that have filters in all panels

elastic / package-spec

EPR package specifications

Other

17 stars 71 forks source link

Accept dashboards without filter that have filters in all panels #687

Closed jsoriano closed 8 months ago

jsoriano commented 9 months ago

What does this PR do?

Checks if dashboards have filters in all panels, if they do, they don't require another filter at the dashboard level.

Why is it important?

Defining the filters in the panels can be more convenient in many use cases, so users are more flexible on the filters they can use, while still limiting searches.

Checklist

[x] I have added test packages to test/packages that prove my change is effective.
[x] I have added an entry in spec/changelog.yml.

Related issues

Fix https://github.com/elastic/package-spec/issues/685

jsoriano commented 9 months ago

Converting to draft till we decide about https://github.com/elastic/package-spec/pull/687#discussion_r1432671169.

jsoriano commented 8 months ago

Reopening for review after implementing the helpers for the validation on kbncontent.

elasticmachine commented 8 months ago

:green_heart: Build Succeeded

Buildkite Build
Commit: 9e33e94fe47320503f6f906bc247253d6fed04fa

History

:broken_heart: Build #488 failed 0e020c22d7d1f335d3fa6f657a21896f4a075d9f
:green_heart: Build #487 succeeded 98a8fa949cb949e25a4baec0541a3fbda1b02f68
:broken_heart: Build #486 failed 161911f4e890bfc5d0d94ac03b8823a34a839932
:broken_heart: Build #485 failed 2b944c111c5336d4bb9b3bdb37535e8d4e498fed
:broken_heart: Build #484 failed 46ad026b4a4490cce0e4da0de9bbe51e15274e66

cc @jsoriano