Refactor tests for field definitions

[jsoriano]

What does this PR do?

Adds a new test for field definitions, whose cases receive as inputs a template package, a set of fields definitions and a list of expected errors. The test builds for each case a new package from the template package and inserts the field definitions, then it runs the validations and checks for the expected errors. A test case looks like this now:

                {
                        title:           "required object type",
                        packageTemplate: "integration_v3_0",
                        fields: []map[string]any{
                                {
                                        "name": "object_without_object_type.*",
                                        "type": "object",
                                },
                        },
                        expectedErrors: []string{
                                `field 0: object_type is required`,
                        },
                },

Test packages whose only purpose was to test field definitions have been removed and their test cases migrated to the new test.

I have decided to validate complete packages so we also validate against semantic rules.

Why is it important?

This approach makes easier to add new test cases for fields. With previous implementation we need to add fields to a package and then add the list of expected errors to a test, with the new approach the field definitions to be tested and the expected errors are together in the same test case. Base packages can be more easily reused, so we don't need to add new packages for each new feature we want to test.

Checklist

• [x] I have added test packages to test/packages that prove my change is effective.
• [ ] I have added an entry in spec/changelog.yml.

Related issues

• Closes #676

[jsoriano]

@mrodm added the option to override the spec version. It has been a bit rabbit hole because we have to modify also the changelog, and take into account that using non-GA versions of the spec also requires the package to have a non-GA version.

I also added an option to apply patches to files. It only supports appending, but is all we need by now.

[elasticmachine]

:green_heart: Build Succeeded

• Buildkite Build
• Commit: 4b5bf9de8bec3d2ecc5557db70ca42fc55b9ecc9

History

• :green_heart: Build #504 succeeded 7e9589da8e9aff25724c66aa287f6e1a99e7dde3

cc @jsoriano

[mrodm]

@mrodm added the option to override the spec version. It has been a bit rabbit hole because we have to modify also the changelog, and take into account that using non-GA versions of the spec also requires the package to have a non-GA version.

I also added an option to apply patches to files. It only supports appending, but is all we need by now.

Oh! I didn't forsee that it would require that many changes, thanks @jsoriano!!