Follow-up to https://github.com/elastic/rally-tracks/pull/563 which missed to update update-custom-package-templates task based on the presence and value of include_non_serverless_index_settings track parameter.
We have 2 overlapping mechanisms for specifying index settings in elastic/logs:
static assets: specifically track-custom-shared-settings.json component template referenced in composable templates, introduced in https://github.com/elastic/rally-tracks/pull/504, it accompanies another track-custom-mappings.json component template,
pre-existing assets: update-custom-package-templates task from index-setup.json, introduced in https://github.com/elastic/rally-tracks/pull/336, based on a custom runner which updates all component templates ending with @custom in the cluster.
The initial idea in https://github.com/elastic/rally-tracks/pull/336 was to only trigger modification of pre-existing assets if specific track parameter is set, but ultimately an overlap scenario was chosen (see this comment). The plan that was never implemented was to get rid of static assets in favor of the custom runner (see this comment).
What I don't like about the custom runner approach is that it modifies all component templates ending with @custom in the cluster (src). What about benchmarks against live clusters? This should be an opt-in, not a default, right?
What I'm proposing in this PR is a logical extension to https://github.com/elastic/rally-tracks/pull/563 which maintains the status quo, but I'm open to extending the scope a bit, and making update-custom-package-templates optional and disabled by default. WDYT?
Follow-up to https://github.com/elastic/rally-tracks/pull/563 which missed to update
update-custom-package-templatestask based on the presence and value ofinclude_non_serverless_index_settingstrack parameter.We have 2 overlapping mechanisms for specifying index settings in
elastic/logs:track-custom-shared-settings.jsoncomponent template referenced in composable templates, introduced in https://github.com/elastic/rally-tracks/pull/504, it accompanies anothertrack-custom-mappings.jsoncomponent template,update-custom-package-templatestask fromindex-setup.json, introduced in https://github.com/elastic/rally-tracks/pull/336, based on a custom runner which updates all component templates ending with@customin the cluster.The initial idea in https://github.com/elastic/rally-tracks/pull/336 was to only trigger modification of pre-existing assets if specific track parameter is set, but ultimately an overlap scenario was chosen (see this comment). The plan that was never implemented was to get rid of static assets in favor of the custom runner (see this comment).
What I don't like about the custom runner approach is that it modifies all component templates ending with
@customin the cluster (src). What about benchmarks against live clusters? This should be an opt-in, not a default, right?What I'm proposing in this PR is a logical extension to https://github.com/elastic/rally-tracks/pull/563 which maintains the status quo, but I'm open to extending the scope a bit, and making
update-custom-package-templatesoptional and disabled by default. WDYT?