search

elastic / rally-tracks

Track specifications for the Elasticsearch benchmarking tool Rally
19 stars 181 forks source link

Remove `index.mode` gate on `copy_to` #654

Closed salvatore-campagna closed 1 month ago

salvatore-campagna commented 1 month ago

This PR will be used to test an implementation of Elasrticsearch that supports copy_to for text fields. We make the field stored to mimic the actual copy_to implementation which will later use a stored field.

salvatore-campagna commented 1 month ago

NOTE: the CI is failing with an error that is expected with Elasticsearch 8.15 (missing copy_to support for text fields in Synthetic Source). This PR, anyway, is tested against an Elasticsearch PR which works-around that issue.

gareth-ellis commented 1 month ago

OK, will this change then be in 8.16? If so we should wait for the feature to merged into elasticsearch main, then backport this to a new 8.16 branch

salvatore-campagna commented 1 month ago

OK, will this change then be in 8.16? If so we should wait for the feature to merged into elasticsearch main, then backport this to a new 8.16 branch

This is using a workaround that I just need for testing purposes. The actual fix will not require setting store: true. So once copy_to is supported it will end-up in Elasticsearch main and I will update this PR so to remove store:true. In the meanwhile I will use it like it is now.

To be more precise I might also close this PR without merging it and just revert the original PR that included the if gate on copy_to.

salvatore-campagna commented 1 month ago

In order to get the original behaviour including copy_to I will just revert the original PR, merge and backport it.