elastic / rally

Macrobenchmarking framework for Elasticsearch
Apache License 2.0
1.95k stars 313 forks source link

Simplify ClusterEnvironmentInfo telemetry device #1779

Closed gbanasiak closed 1 year ago

gbanasiak commented 1 year ago

ClusterEnvironmentInfo telemetry device unnecessarily calls nodes stats API to populate metadata fields in a metric store which duplicates ExternalEnvironmentInfo. As ClusterEnvironmentInfo is not tagged with serverless.Status.Internal status, the additional bonus of the simplification is unblocking Rally when ran with public serverless privileges.

I've tested the change comparing metric store content (rally-metrics-*) with/without simplification. On each run the amount of documents with the following fields was equal: