Skip metrics that are missing in either contender or baseline

elastic / rally

Macrobenchmarking framework for Elasticsearch

Apache License 2.0

1.95k stars 313 forks source link

Skip metrics that are missing in either contender or baseline #1803

Closed gareth-ellis closed 10 months ago

gareth-ellis commented 10 months ago

Fixes: #1802

This fixes compare failing if a metric is missing from one of baseline or contender. It seems this functionality was partly thought about already via e.g #1482 though this adds further protection.

gareth-ellis commented 10 months ago

Sure - i've removed the logic around the warning. I have pushed to my branch, however the PR hasnt updated yet...

gbanasiak commented 10 months ago

Thank you for iterating, LGTM.