search

elastic / ruby-lumberjack

Ruby lumberjack protocol, contains both client and server
Other
4 stars 17 forks source link

Whoa we shouldn't get this frame #1

Open celesteking opened 9 years ago

celesteking commented 9 years ago

Guys, is this right repo to log issues against lumberjack ruby client? Great!

Here's a test case:

  1. send normally using client
  2. terminate logstash
  3. try to write some more data using client
  4. get the error:
RuntimeError: Whoa we shouldn't get this frame:  : /home/lst/lst/vendor/bundle/ruby/2.1.0/gems/jls-lumberjack-0.0.22/lib/lumberjack/client.rb:116:in `ack',
/home/lst/lst/vendor/bundle/ruby/2.1.0/gems/jls-lumberjack-0.0.22/lib/lumberjack/client.rb:109:in `write_hash',
/home/lst/lst/vendor/bundle/ruby/2.1.0/gems/jls-lumberjack-0.0.22/lib/lumberjack/client.rb:44:in `write'

Ideas on fixing this are welcome. Ideally, there should be a notification that server is gone and either auto-reconnection code added or just an exception thrown to user that connection is dead.

ph commented 9 years ago

https://github.com/logstash-plugins/logstash-input-lumberjack/pull/8

As soon as the PR is rebased and the CLA signed I'll merge it.

celesteking commented 9 years ago

That's unrelated. I'm talking about lumberjack/client.rb , not about logstash input plugin.

ph commented 9 years ago

Sorry read too fast, yes this is the right place.

aadicodes commented 8 years ago

I am trying to ship filtered logs from one logstash to another using lumberjack output plugin. I got similar error. Appreciate if any inputs on how to fix it ?

Client write error, trying connect {:e=>#<RuntimeError: Whoa we shouldn't get this frame: >, :backtrace=>["/opt/logstash/logstash/vendor/bundle/jruby/1.9/gems/jls-lumberjack-0.0.26/lib/lumberjack/client.rb:146:in `ack'", "/opt/logstash/logstash/vendor/bundle/jruby/1.9/gems/jls-lumberjack-0.0.26/lib/lumberjack/client.rb:13

jordansissel commented 8 years ago

That error does not seem similar to me. Can you open another ticket?

On Wednesday, September 7, 2016, aadicodes notifications@github.com wrote:

I am trying to ship filtered logs from one logstash to another using lumberjack output plugin. I got similar error. Appreciate if any inputs on how to fix it ?

Client write error, trying connect {:e=>#, :backtrace=>["/opt/logstash/ logstash/vendor/bundle/jruby/1.9/gems/jls-lumberjack-0.0. 26/lib/lumberjack/client.rb:146:in `ack'", "/opt/logstash/logstash/ vendor/bundle/jruby/1.9/gems/jls-lumberjack-0.0.26/lib/ lumberjack/client.rb:13

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/elastic/ruby-lumberjack/issues/1#issuecomment-245414531, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIC6kZDUoihX40X4gLfu_zsFqg82xboks5qnyODgaJpZM4ElHOD .

stevenh commented 4 years ago

seeing this as well connecting to golang servers

ph commented 4 years ago

@stevenh Which library are you using for the server part? our official one?

stevenh commented 4 years ago

Deleted previous replies, had the wrong tab open, will check what lib it's using at the other end.