elastic / ruby-lumberjack

Ruby lumberjack protocol, contains both client and server
Other
4 stars 17 forks source link

Add support for plain tcp connection #14

Closed urso closed 9 years ago

urso commented 9 years ago

for using plain tcp socket, SSL/TLS support must be explicitly disabled by setting the option ‘ssl’ to false.

urso commented 9 years ago

PR for #12

ph commented 9 years ago

@urso I did a small pass on it.

I think the only thing we need to do is to make sure all the examples run in both context SS on/off, since they are mostly integration test and this should be easy to do if we refactor them into a shared example.

Also we need to make sure we add tests for incompatible configuration of client and server. IE: a Client with SSL ON connect to a Server with SSL off, people will mess up their config and the error should bubble up to the input and be explicit enough.

urso commented 9 years ago

Difficult to make error explicit enough. For the ssl based client/server it's a handshake error. But for tcp based client/server it's some invalid data being received making the parser trip. That's due to the nature of SSL being right on top of TCP. I can not distinguish between invalid data received or connect to/from SSL connection. Maybe related #1

ph commented 9 years ago

@urso Yeah, Oh computers! I'll do a bit of testing on my end with this PR.

sandstrom commented 9 years ago

@urso Thanks for this, much appreciated! :boat:

ph commented 9 years ago

@urso LGTM good work merging this!

I have a few more PRs to get in before releasing a new version!

elasticsearch-bot commented 9 years ago

Merged sucessfully into master!