search

elastic / ruby-lumberjack

Ruby lumberjack protocol, contains both client and server
Other
4 stars 17 forks source link

Added option for an SSL certificate chain to lumberjack server #2

Closed thefinn93 closed 9 years ago

thefinn93 commented 9 years ago

I tested it with logstash-forwarder and it worked well. I've submitted a pull request at https://github.com/logstash-plugins/logstash-input-lumberjack/pull/30 to make use of these changes

suyograo commented 9 years ago

@thefinn93 can you please sign the CLA? https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md#contribution-steps

thefinn93 commented 9 years ago

Done

suyograo commented 9 years ago

@thefinn93 thanks, this patch has been submitted with @finn.io email address. Can you please sign the CLA with this address? Also can you rebase?

thefinn93 commented 9 years ago

There we go, should all be good.

cspenceiv commented 9 years ago

As I was preparing to send my pull request for the same issue, I this request was already here. I still decided to still submit my request as an alternative solution.

Note that my solution does not require changes to any other code using the Server Class.

thefinn93 commented 9 years ago

Ah nice, much cleaner than mine. +1 for #20

cspenceiv commented 9 years ago

Thank you!

suyograo commented 9 years ago

Closing this in favor of #20