search

elastic / ruby-lumberjack

Ruby lumberjack protocol, contains both client and server
Other
4 stars 17 forks source link

ssl_certificate never used in Client #4

Closed lazyfrosch closed 9 years ago

lazyfrosch commented 9 years ago

Prove me wrong, but I think the ssl_certificate is never used in client.

So the connection to a server doesn't get validated?

ph commented 9 years ago

I've been looking through the code and yes this settings seem to be not used but required.

ph commented 9 years ago

thanks to @jsvd's archeology skills it used to be there https://github.com/elastic/ruby-lumberjack/blob/ea49476be4c8fb3893b9f1e67b34e6277c44df24/lib/lumberjack/client.rb#L77

lazyfrosch commented 9 years ago

But even the verification is disabled there :cry:

ph commented 9 years ago

@lazyfrosch I'll fix it :( I am messing with another SSL problem so I'll do it at the same time.

lazyfrosch commented 9 years ago

@ph thanks for that :smile: