elastic / search-application-client

Apache License 2.0
4 stars 4 forks source link

Make params in SearchApplicationClient optional #30

Closed timgrein closed 1 year ago

timgrein commented 1 year ago

The internal Client class seems to have two optional parameters baseParams? and requestHeaders?. The public API of SearchApplicationClient requires params to be present. As they're not checked if they're present and the underyling client doesn't require params I guess it makes more sense to adapt the params to be optional as this feels a bit inconvenient when using the client, but maybe I've got something wrong here.

I've also added missing tests for the SearchApplicationClient with this PR.