elastic / search-ui

Search UI. Libraries for the fast development of modern, engaging search experiences.
https://docs.elastic.co/search-ui
Apache License 2.0
1.92k stars 368 forks source link

Ignore `dist` from linting #976

Closed wentaoxu415 closed 1 year ago

wentaoxu415 commented 1 year ago

Is your feature request related to a problem? Please describe. As of now, eslint based on the configuration specified in the root directory's package.json can still lint against files in the dist directories which can make linting fail. The configuration should be updated to also ignore all dist directories.

Describe the solution you'd like Ignore all dist directories for linting. Specifically, update the lint command in the root directory's package.json to be the following:

"lint": "eslint --ignore-path .gitignore . --ignore-pattern '**/node_modules/**' --ignore-pattern '**/build/**' --ignore-pattern '**/dist/**'"

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

botelastic[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.