elastic / search-ui

Search UI. Libraries for the fast development of modern, engaging search experiences.
https://docs.elastic.co/search-ui
Apache License 2.0
1.92k stars 368 forks source link

Correct exports for nuxt/svelte #984

Closed ehibes closed 6 months ago

ehibes commented 1 year ago

Description

On Nuxt3 or Svelte projects, an 500 error is returned with this message :

SyntaxError: Named export 'SearchDriver' not found. The requested module '@elastic/search-ui' is a CommonJS module, which may not support all module.exports as named exports.

List of changes

Add correct exports on package.json files to use ESM module on SvelteKit or Nuxt

"exports": {
    ".": {
      "import": "./lib/esm/index.js",
      "require": "./lib/cjs/index.js"
    }
  }
}

Associated Github Issues

Resolve #952 #938 #953

cla-checker-service[bot] commented 1 year ago

💚 CLA has been signed

ehibes commented 1 year ago

I signed the Contributor Agreement, how to recheck it ?

botelastic[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

botelastic[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

Finnepinnen commented 8 months ago

It looks like this was not merged into the elastic:main @joemcelroy

ehibes commented 8 months ago

Yes, I confirm that it was not merged. Can you reopen this pull request ?

Finnepinnen commented 8 months ago

Is there anything I can do to bump this pull request?

Finnepinnen commented 6 months ago

I'm so excited to get this reviewed!

miguelgrinberg commented 6 months ago

Moved to #1043