search

elastic / search-ui

Search UI. Libraries for the fast development of modern, engaging search experiences.
https://docs.elastic.co/search-ui
Apache License 2.0
1.92k stars 368 forks source link

Out of date dependency "core-js" being used in @elastic/react-search-ui-views #991

Closed judithtarot closed 12 months ago

judithtarot commented 1 year ago

Is your feature request related to a problem? Please describe.

When the @elastic/react-search-ui-views modules are being built this warning appears:

[1/5] 🔍  Resolving packages...
warning @elastic/react-search-ui > @elastic/react-search-ui-views > rc-pagination > babel-runtime > core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.

This makes me concerned that some of our users might be having a poor search experience.

Describe the solution you'd like

Upgrade the version of "rc-pagination" being used in "@elastic/react-search-ui-views". It is asking for "^1.20.1" which is 4 years old and has that unrecommended dependency. The current version of "rc-pagination" is "3.6.1"

Describe alternatives you've considered I am using your js/react modules, and they usually work well, so I would like to be able to continue using them.

botelastic[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

M-Brico commented 8 months ago

This is still an issue surely?

npm WARN deprecated core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.

joemcelroy commented 8 months ago

fixed in 1.21.0