search

elastic / snyk-github-issue-creator

CLI tool for creating GitHub issues from Snyk project issues
5 stars 6 forks source link

Add support for the new Critical severity level. #17

Closed jportner closed 3 years ago

jportner commented 3 years ago

References

We should release a new version after merging this. It is not a backwards-incompatible change, so I think a new minor would be fine.

jportner commented 3 years ago

FYI: I was told by Snyk that the old deprecated API we still use does not support the critical level and that we would have to wait till we moved to the new API before we could get access to it. But I guess this is all that's needed to support it once we do get access to it 🤔

Maybe we shouldn't publish a new version yet, then? If I have some time I'll try to come up with a test repo with a Critical vulnerability so we can see what happens. Certainly the vulnerability is not just excluded from the API results. Maybe the deprecated API returns it as High severity instead?

watson commented 3 years ago

Maybe we shouldn't publish a new version yet, then?

Yeah I don't see any reason as long as we still use the deprecated API.

If I have some time I'll try to come up with a test repo with a Critical vulnerability so we can see what happens. Certainly the vulnerability is not just excluded from the API results. Maybe the deprecated API returns it as High severity instead?

All "critical" is just labeled "high" in the deprecated API.