elastic / support-diagnostics

Support diagnostics utility for elasticsearch and logstash
Other
289 stars 150 forks source link

Make failure error more obvious #691

Closed stefnestor closed 1 month ago

stefnestor commented 1 month ago

👋 howdy, team!

We have users uploading empty (other than diagnostics.log) diagnostics to Support. AFAICT most come via the Fatal error occurred code path. This PR updates light console formatting to make this failure more obvious to users unfamiliar with our diagnostic (via a line-break and all-caps) so that they can rectify errors before uploading to reduce resolution time.

TIA! 🙏

stefnestor commented 1 month ago

Also noting if only a handful of API calls fail for HTTP 403 reasons that error is much more apparent & could be considered here as well, e.g.


************************************************************
************************************************************
************************************************************
The elasticsearch user entered: elastic does not appear to have sufficient authorization to access all collected information
Some of the calls may not have completed successfully.
If you are using a custom role please verify that it has the admin role for versions prior to 5.x or the superuser role for subsequent versions.
************************************************************
************************************************************
************************************************************