elastic / synthetics-demo

Demo app for elastic/synthetics
https://elastic.github.io/synthetics-demo/
MIT License
2 stars 11 forks source link

Remove continue on error for GH actions #31

Closed andrewvc closed 1 year ago

andrewvc commented 1 year ago

We have been using workflows wrong, before #27 we had the junit action exit with a bad status code. Rather, the step before should fail with that step merely doing reporting. v1 of the junit workflow supported our previous incorrect method, v2 recommends against it.

You can see an example of this working with a failing test in #30

github-actions[bot] commented 1 year ago

Elastic Synthetics Tests

4 tests  ±0   4 :heavy_check_mark: ±0   0s :stopwatch: -1s 1 suites ±0   0 :zzz: ±0  1 files   ±0   0 :x: ±0 

Results for commit a6036829. ± Comparison against base commit b813db84.

:recycle: This comment has been updated with latest results.