search

elastic / template-kibana-plugin

sao.js template for kibana plugins
Apache License 2.0
64 stars 34 forks source link

No need to install template globally #11

Closed egoist closed 7 years ago

egoist commented 7 years ago

Since SAO will automatically install template at ~/sao/packages now (not global node_modules directory)

w33ble commented 7 years ago

So it will automatically pull it down as template-<name> from npm (template-kibana-plugin in our case)? That's pretty cool.

As I understand the old behavior, this doesn't automatically happen, so I'm worried about people who might have an older global sao installed. If they run sao kibana-plugin, they're going to get a message that the template can't be found, right?

In that case, I wonder if it's better to recommend using sao elastic/template-kibana-plugin, since it works in both cases...

w33ble commented 7 years ago

Actually, that's tricky too, since it doesn't look like installing from a repo url works with the version option (at least with 0.19.9, which is what I happen to have installed right now).

@egoist Was there a way to install from a tag and a repo path in the older versions of sao?

egoist commented 7 years ago

If they run sao kibana-plugin, they're going to get a message that the template can't be found, right?

Not really, this has been implemented since a long time ago (v0.16.11), there was be a prompt to ask user whether to install missing template, but we removed the prompt in 0.22.1 (current) and install the missing template directly now 😄

Actually, that's tricky too, since it doesn't look like installing from a repo url works with the version option

That's supported in v0.21.0 or greater.

w33ble commented 7 years ago

Oh, I've seen that message before, but I didn't realize it would append the template- part and go fetch it. I just tried it, and sure enough, it works as expected. Nice.

Thanks for the PR and the info! 🏆