elastic / template-kibana-plugin

sao.js template for kibana plugins
Apache License 2.0
64 stars 34 forks source link

Unable to run with default template with particular plugin naming #14

Closed ppadovani closed 6 years ago

ppadovani commented 6 years ago

Can you please update your documentation to indicate that plugin names cannot:

This caused me much frustration.

w33ble commented 6 years ago

The template will convert whatever name you give it to the correct format. I'm happy to update or add to any documentation you're talking about though.

We don't have a lot of documentation, other than what's in the template here. Where would you like to see this mentioned?

ppadovani commented 6 years ago

It didn't for my first three attempts, not sure why. Perhaps not enough coffee?

Just something in the README. For example right above this HINT:

HINT: If you need to use a version other than the latest, you can specify it when you run the template

You could just add something like: NOTE: The plugin name, not repository name, must contain all lowercase letters, no dots or underscores.

w33ble commented 6 years ago

It didn't for my first three attempts, not sure why. Perhaps not enough coffee?

Let us know what names didn't work, that sounds like a bug.

In the meantime, I'll get a note about the name into the README.

w33ble commented 6 years ago

Closing for lack of response. We can re-open if needed.