elastic / template-kibana-plugin

sao.js template for kibana plugins
Apache License 2.0
64 stars 34 forks source link

link to @kbn/plugin-helpers when targeting 6.3+ #18

Closed spalger closed 6 years ago

spalger commented 6 years ago

Once https://github.com/elastic/kibana/pull/16565 is merged the template will need to link to the @kbn/plugin-helpers package from the Kibana repo rather than installing it from NPM. I'm assuming we can do that just for packages targeting 6.3 or greater, which I think means we'll need to cut a new 7.x release for 6.3+ and a new 8.x release for 7.0+

w33ble commented 6 years ago

@spalger do we still need this? Aren't we using kbn-plugin-generator in 6.3+?

spalger commented 6 years ago

Yeah, this is taken care of by kbn-plugin-generator