search

elastic / template-kibana-plugin

sao.js template for kibana plugins
Apache License 2.0
64 stars 34 forks source link

moving plugin template to React and EUI #20

Closed bmcconaghy closed 6 years ago

bmcconaghy commented 6 years ago

updating Kibana plugin template to use React and EUI.

kimjoar commented 6 years ago

@bmcconaghy We recently moved the plugin generator to https://github.com/elastic/kibana/tree/master/packages/kbn-plugin-generator, for all new plugins (6.3 and greater). We definitely want this change there, but not sure about applying it here. Maybe move this PR there first, so we can merge it there, then potentially "backport" it here (aka reopen this PR)?

bmcconaghy commented 6 years ago

@cjcenizal made these changes in the corresponding PR for Kibana. This repo is deprecated apparently.

kimjoar commented 6 years ago

(The deprecation is mentioned in the first line in the readme. We haven’t archived the github repo as it’s still used for Kibana versions prior to 6.3)

spalger commented 6 years ago

I like your feedback @w33ble, but I would really to reiterate @kjbekkelund and suggest that this be reopened and reviewed in the Kibana repo and backported from there if desired.

w33ble commented 6 years ago

@spalger near as I can tell, this is https://github.com/elastic/kibana/pull/16937 applied to the standalone tool here. FWIW, I'm in favor of closing this PR until we settle on the changes there. Concurrent PR's are just going to muddy the waters (I didn't realize that was happening until after I left comments here).